View Issue Details

IDProjectCategoryView StatusLast Update
0001633K18X001.00 SKB SWANSWpublic2023-02-02 08:53
Reporter(ALTech) Sangmin Choi Assigned To(ALTech) Sangmin Choi Due Date2023-02-01 18:00
PrioritynormalSeveritys4-minorReproducibilityN/A
Status closedResolutionreopened 
Summary0001633: Please apply this patch from BTVSBOX-630.
DescriptionHi, Jason,

Please apply this patch from BTVSBOX-630.

Commit Message is as follows.
[BTVSBOX-630]
Root cause : Regression of "[BTVSBOX-501] Fix unmute issue". which keep mute state if the volume is configured 0.
Solution : Releasing mute if the application set the non-zero volume.

syna-release/ampsdk
CSMSKBSBLT-201-Unmute-HDMI.patch

Thank you.
TagsNo tags attached.
Attach Tags

Users monitoring this issue

User List (SW) Dean Chiang , (SW) Jim Chen

Activities

(ALTech) Sangmin Choi

2023-02-01 10:55

developer  

CSMSKBSBLT-201-Unmute-HDMI.patch (2,384 bytes)   
diff --git a/amp/src/aal/sound/sound_api.c b/amp/src/aal/sound/sound_api.c
index 27c374c..ac3b5dd 100755
--- a/amp/src/aal/sound/sound_api.c
+++ b/amp/src/aal/sound/sound_api.c
@@ -3067,6 +3067,7 @@ HRESULT AMP_SND_SetStreamVolumeIndB(AMP_IN HANDLE hStream, AMP_IN float fVolume)
     SND_STRM *pStream = 0;
     UINT32 uiVolume = 0;
     AMP_APP_PARAST stAppParam;
+    AMP_SOUND_DRIVER *pSndDrv = g_stSndDriver;
 
     SND_API_ENTER();
     SNDDRV_CHECKVALID();
@@ -3097,6 +3098,7 @@ HRESULT AMP_SND_SetStreamVolumeIndB(AMP_IN HANDLE hStream, AMP_IN float fVolume)
         (pStream->PeerPortConn.hInterHandle == SOUND_PORTID_PASSTHROUGH &&
         pStream->PeerPortConn.uiFlags == HDMI_PATH))
     {
+        MV_OSAL_Mutex_Lock(pSndDrv->hDrvMutex);
 #ifdef CONFIG_AMP_AUDIO_MUTE_PT_FOR_STREAM
         SNDLOGD("HDMI pass through case, stream volume is set to AOUT!\n");
         AMP_RPC(rc, AMP_SNDSINK_SetAoutStreamVolume, pStream->hSndSinkComp,
@@ -3109,6 +3111,11 @@ HRESULT AMP_SND_SetStreamVolumeIndB(AMP_IN HANDLE hStream, AMP_IN float fVolume)
 #if 1  //tony debug
         pStream->uiStreamVolume = uiVolume;
 #endif 
+        if( pStream->uiStreamVolume != 0 ){
+            AMP_RPC(rc, AMP_SNDSINK_SetAoutStreamVolume, pStream->hSndSinkComp, HDMI_PATH, 0x40000000L);
+        }
+        MV_OSAL_Mutex_Unlock(pSndDrv->hDrvMutex);
+
         return rc;
     }
 
@@ -3482,7 +3489,6 @@ HRESULT AMP_SND_SetStreamMute(AMP_IN HANDLE hStream, AMP_IN BOOL bMute)
     SNDSTRM_CHECKVALID(hStream);
     pStream = (SND_STRM *)hStream;
     stAppParam._d = AMP_APP_PARAIDX_VOLUME;
-
     
     if((pStream->PeerPortConn.ePeerType == AMP_PORT_AREN_OUT_SPDIF)||
         (pStream->PeerPortConn.hInterHandle == SOUND_PORTID_PASSTHROUGH &&
@@ -3530,6 +3536,7 @@ HRESULT AMP_SND_SetStreamMute(AMP_IN HANDLE hStream, AMP_IN BOOL bMute)
         (pStream->PeerPortConn.hInterHandle == SOUND_PORTID_PASSTHROUGH &&
         pStream->PeerPortConn.uiFlags == HDMI_PATH))
     {
+        MV_OSAL_Mutex_Lock(pSndDrv->hDrvMutex);
 #ifdef CONFIG_AMP_AUDIO_MUTE_PT_FOR_STREAM
         SNDLOGD("HDMI pass through case, stream volume is set to AOUT!\n");
 #if 1 //tony debug
@@ -3545,6 +3552,7 @@ HRESULT AMP_SND_SetStreamMute(AMP_IN HANDLE hStream, AMP_IN BOOL bMute)
                      hStream);
         }
 #endif
+        MV_OSAL_Mutex_Unlock(pSndDrv->hDrvMutex);
         return rc;
     }
 

(SW) Dean Chiang

2023-02-01 11:31

developer   ~0011937

Hi Sangmin,

Patch has been applied to 536 branch.

Thank you.
Dean Chiang

Issue History

Date Modified Username Field Change
2023-02-01 10:55 (ALTech) Sangmin Choi New Issue
2023-02-01 10:55 (ALTech) Sangmin Choi Status new => assigned
2023-02-01 10:55 (ALTech) Sangmin Choi Assigned To => (SW) Jason Ling
2023-02-01 10:55 (ALTech) Sangmin Choi File Added: CSMSKBSBLT-201-Unmute-HDMI.patch
2023-02-01 10:55 (ALTech) Sangmin Choi Issue Monitored: (SW) Dean Chiang
2023-02-01 10:55 (ALTech) Sangmin Choi Issue Monitored: (SW) Jim Chen
2023-02-01 11:07 (SW) Jason Ling Assigned To (SW) Jason Ling => (SW) Dean Chiang
2023-02-01 11:31 (SW) Dean Chiang Note Added: 0011937
2023-02-01 12:30 (ALTech) Sangmin Choi Description Updated
2023-02-02 08:53 (ALTech) Sangmin Choi Status assigned => closed
2023-02-02 08:53 (ALTech) Sangmin Choi Resolution open => fixed
2023-02-02 08:53 (ALTech) Sangmin Choi Status closed => feedback
2023-02-02 08:53 (ALTech) Sangmin Choi Resolution fixed => reopened
2023-02-02 08:53 (ALTech) Sangmin Choi Assigned To (SW) Dean Chiang => (ALTech) Sangmin Choi
2023-02-02 08:53 (ALTech) Sangmin Choi Status feedback => closed